Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-beta-bin-unwrapped: 69.0b16 -> 71.0b6 #72601

Merged
merged 1 commit into from Nov 3, 2019
Merged

firefox-beta-bin-unwrapped: 69.0b16 -> 71.0b6 #72601

merged 1 commit into from Nov 3, 2019

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Nov 2, 2019

Motivation for this change

Firefox beta is behind. Release notes at https://www.mozilla.org/en-US/firefox/71.0beta/releasenotes/.

Things done
$ nix-shell maintainers/scripts/update.nix --argstr package firefox-beta-bin-unwrapped
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @taku0

@FRidh
Copy link
Member

FRidh commented Nov 3, 2019

@GrahamcOfBorg build firefox-beta-bin

@FRidh FRidh requested a review from taku0 November 3, 2019 09:09
taku0
taku0 approved these changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have built and ran it successfully.

@FRidh FRidh merged commit 9e352d9 into NixOS:master Nov 3, 2019
@jonafato jonafato deleted the firefox-beta-bin-69.0b16-71.0b6 branch November 3, 2019 14:22
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 3, 2019
@FRidh @dtzWill
Merge pull request NixOS#72601 from jonafato/firefox-beta-bin-69.0b16…
258df14 
…-71.0b6

firefox-beta-bin-unwrapped: 69.0b16 -> 71.0b6
(cherry picked from commit 9e352d9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonafato @FRidh @taku0