Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/ofborg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a4dc3d020b92
Choose a base ref
...
head repository: NixOS/ofborg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 78d1395ce5c9
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Nov 2, 2019

  1. fix dyn stuff

    grahamc committed Nov 2, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    grahamc Graham Christensen
    Copy the full SHA
    78d1395 View commit details
Showing with 7 additions and 7 deletions.
  1. +1 −1 ofborg/src/notifyworker.rs
  2. +1 −1 ofborg/src/outpathdiff.rs
  3. +4 −4 ofborg/src/tasks/build.rs
  4. +1 −1 ofborg/src/tasks/evaluate.rs
2 changes: 1 addition & 1 deletion ofborg/src/notifyworker.rs
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ pub struct NotifyWorker<T: SimpleNotifyWorker> {
pub trait SimpleNotifyWorker {
type J;

fn consumer(&self, job: &Self::J, notifier: &mut NotificationReceiver);
fn consumer(&self, job: &Self::J, notifier: &mut dyn NotificationReceiver);

fn msg_to_job(
&self,
2 changes: 1 addition & 1 deletion ofborg/src/outpathdiff.rs
Original file line number Diff line number Diff line change
@@ -110,7 +110,7 @@ type Package = String;
type Architecture = String;
type OutPath = String;

pub fn parse_lines(data: &mut BufRead) -> PackageOutPaths {
pub fn parse_lines(data: &mut dyn BufRead) -> PackageOutPaths {
data.lines()
.filter_map(|line| match line {
Ok(line) => Some(line),
8 changes: 4 additions & 4 deletions ofborg/src/tasks/build.rs
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ impl BuildWorker {
fn actions<'a, 'b>(
&self,
job: &'b buildjob::BuildJob,
receiver: &'a mut notifyworker::NotificationReceiver,
receiver: &'a mut dyn notifyworker::NotificationReceiver,
) -> JobActions<'a, 'b> {
JobActions::new(&self.system, &self.identity, job, receiver)
}
@@ -50,7 +50,7 @@ impl BuildWorker {
pub struct JobActions<'a, 'b> {
system: String,
identity: String,
receiver: &'a mut notifyworker::NotificationReceiver,
receiver: &'a mut dyn notifyworker::NotificationReceiver,
job: &'b buildjob::BuildJob,
line_counter: u64,
snippet_log: VecDeque<String>,
@@ -66,7 +66,7 @@ impl<'a, 'b> JobActions<'a, 'b> {
system: &str,
identity: &str,
job: &'b buildjob::BuildJob,
receiver: &'a mut notifyworker::NotificationReceiver,
receiver: &'a mut dyn notifyworker::NotificationReceiver,
) -> JobActions<'a, 'b> {
let (log_exchange, log_routing_key) = job
.logs
@@ -279,7 +279,7 @@ impl notifyworker::SimpleNotifyWorker for BuildWorker {
fn consumer(
&self,
job: &buildjob::BuildJob,
notifier: &mut notifyworker::NotificationReceiver,
notifier: &mut dyn notifyworker::NotificationReceiver,
) {
let mut actions = self.actions(&job, notifier);

2 changes: 1 addition & 1 deletion ofborg/src/tasks/evaluate.rs
Original file line number Diff line number Diff line change
@@ -156,7 +156,7 @@ impl<E: stats::SysEvents + 'static> worker::SimpleWorker for EvaluationWorker<E>
}
};

let mut evaluation_strategy: Box<eval::EvaluationStrategy> = if job.is_nixpkgs() {
let mut evaluation_strategy: Box<dyn eval::EvaluationStrategy> = if job.is_nixpkgs() {
Box::new(eval::NixpkgsStrategy::new(
&job,
&pull,