Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: disable update check machanism #72509

Merged
merged 1 commit into from Nov 2, 2019
Merged

kitty: disable update check machanism #72509

merged 1 commit into from Nov 2, 2019

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Nov 2, 2019

Motivation for this change

kitty has its own update notification mechanism which should probably be disabled when the package is managed by a package manager such as nix. See https://sw.kovidgoyal.net/kitty/build.html#note-for-linux-macos-packagers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tex @rvolosatovs @Ma27

@Luflosi
kitty: disable update check machanism
326583f 
kitty has its own update notification mechanism which should probably be disabled when the package is managed by a package manager such as nix. See https://sw.kovidgoyal.net/kitty/build.html#note-for-linux-macos-packagers.
@ofborg ofborg bot requested a review from Ma27 November 2, 2019 01:33
@Ma27 Ma27 merged commit 47bd854 into NixOS:master Nov 2, 2019
@Ma27
Copy link
Member

Ma27 commented Nov 2, 2019

Thanks! Backported as 2b2ab75.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Nov 2, 2019
@Luflosi Luflosi deleted the kitty-no-update branch November 2, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luflosi @Ma27