waylandpp: 0.2.5 -> 0.2.7, make it split-output package #72420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minijackson
force-pushed
the
waylandpp-0.2.7
branch
from
409e2a9
to
34999b0
Compare
|
@GrahamcOfBorg build kodi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bigger numbers is better. Multiple output packages are nicer, and better for cross-compilation (although I didn't test cross compilation).
It wasn't possible to upgrade to Waylandpp 0.2.6 because kodi-wayland failed to compile, but this was fixed with this waylandpp commit.
Closes #70811
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Result of
nix-review13 package were build:
Notify maintainers
That's me.
For the Kodi modifications:
@domenkozar @titanous @edwtjo @peterhoeg @sephalon