Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nginx: update comment #72719

Merged
merged 1 commit into from Nov 18, 2019
Merged

nixos/nginx: update comment #72719

merged 1 commit into from Nov 18, 2019

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Nov 3, 2019 •
edited

It says Apache, but this is for Nginx; this does not appear to be referenced anywhere by the httpd nixos module.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bhipple
nixos/nginx: update comment
3d73b6d 
It says Apache, but this is for Nginx; looks like a copy-paste error.
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2019 •
edited

It seems there is the same typo in the header of nginx / vhost-options.nix

@Lassulus Lassulus merged commit 14961b1 into NixOS:master Nov 18, 2019
@bhipple bhipple deleted the doc/comment-fix branch December 3, 2019 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bhipple @c0bw3b @tomberek @Lassulus