lkvm: init from https://git.kernel.org/pub/scm/linux/kernel/git/will/kvmtool.git #72699
Conversation
|
Hi, any chance to get this merged? |
zokrezyl
requested review from
adisbladis,
alyssais,
edolstra,
edwtjo,
Ericson2314,
FRidh,
infinisil,
joachifm,
jtojnar,
matthewbauer,
nbp,
peti,
Profpatsch,
rycee,
tfc,
thoughtpolice,
ttuegel and
WilliButz
as code owners
jtojnar
removed request for
alyssais,
edolstra,
edwtjo,
Ericson2314,
FRidh,
joachifm,
jtojnar,
matthewbauer,
nbp,
peti,
Profpatsch,
rycee,
tfc,
thoughtpolice and
ttuegel
| buildInputs = [ libbfd zlib libaio glibc glibc.static]; | ||
|
|
||
| buildPhase = '' | ||
| make all |
There was a problem hiding this comment.
You can use buildFlags = [ "all" ]; but reading https://git.kernel.org/pub/scm/linux/kernel/git/will/kvmtool.git/tree/INSTALL, the default buildPhase should be enough.
There was a problem hiding this comment.
This does not seem to be resolved. What happens when you remove the buildPhase and leave it to the default value?
| { stdenv, fetchgit, libbfd, zlib, libaio, glibc }: | ||
|
|
||
| stdenv.mkDerivation { | ||
| name = "kvmtool"; |
There was a problem hiding this comment.
This should be pname (or include the version.)
Specifying a name and a src is the absolute minimum Nix requires. For convenience, you can also use pname and version attributes and mkDerivation will automatically set name to "${pname}-${version}" by default. Since RFC 0035, this is preferred for packages in Nixpkgs
— https://nixos.org/nixpkgs/manual/#sec-using-stdenv
This is for nix-env, where it only looks at the name field of derivations to distinguish between versions.
| sha256 = "0kyb3rm98wzwgjs06crcgb39547rr4px4vap8ivm7yqnwbphr67f"; | ||
| }; | ||
|
|
||
| buildInputs = [ libbfd zlib libaio glibc glibc.static]; |
There was a problem hiding this comment.
Maybe add a comment why static glibc is needed:
| buildInputs = [ libbfd zlib libaio glibc glibc.static]; | |
| buildInputs = [ | |
| libbfd | |
| zlib | |
| libaio | |
| glibc | |
| glibc.static # for guest init | |
| ]; |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
closing as abandoned |
Motivation for this change
New expression
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)