Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme-jade1: 3.3 -> 1.5 #72581

Merged
merged 2 commits into from Nov 3, 2019
Merged

theme-jade1: 3.3 -> 1.5 #72581

merged 2 commits into from Nov 3, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Nov 2, 2019

Motivation for this change

Update to version 1.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo changed the title theme-jade1: 3.3 -> 1.4 theme-jade1: 3.3 -> 1.5 Nov 2, 2019
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious versioning choice from upstream but ok

@c0bw3b c0bw3b merged commit c7fdfc4 into NixOS:master Nov 3, 2019
@romildo romildo deleted the upd.theme-jade1 branch November 3, 2019 10:18
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 3, 2019
theme-jade1: 3.3 -> 1.5
(cherry picked from commit c7fdfc4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants