nixos: default environment.homeBinInPath to false
#72584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
reviewed
Nov 2, 2019
andir
force-pushed
the
homeInPath-false
branch
from
4a8f65a
to
c97a0ec
Compare
|
/cc @edolstra |
|
Maybe this could look at the stateVersion? I would find that a reasonable use of stateVersion. |
|
@andir This seems fine to me, didn't get much more response so feel free to rebase and merge. |
worldofpeace
approved these changes
Nov 25, 2019
andir
force-pushed
the
homeInPath-false
branch
from
c97a0ec
to
afe79c8
Compare
This is a more sane default since we do not magically (without opt-in) pull in binaries from `~/bin`. That is not really an expected behavior for many users. Users that still want that behavior can now just flip that switch.
andir
force-pushed
the
homeInPath-false
branch
from
afe79c8
to
a06529b
Compare
|
Not really in favor of this. It seems like an unnecessary incompatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a more sane default since we do not magically (without opt-in)
pull in binaries from
~/bin. That is not really an expected behaviorfor many users. Users that still want that behavior can now just flip
that switch.
cc @chkno @worldofpeace both have been involved in #68483
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)