Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flask-cors: fix build #72479

Merged
merged 1 commit into from Nov 1, 2019
Merged

pythonPackages.flask-cors: fix build #72479

merged 1 commit into from Nov 1, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 1, 2019 •
edited

Motivation for this change

Fixes #72446
cc: @sjau

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Copy link
Contributor Author

marsam commented Nov 1, 2019

@GrahamcOfBorg build flexget

jonringer
jonringer reviewed Nov 1, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although this allows for the tests to pass, is it invalidating the point of the tests? I'm not super familiar with flask-cors, but it could be making assumptions about when flask is meant to throw exceptions, just ignoring the tests might not assure that the package is still working correctly.

@marsam
Copy link
Contributor Author

marsam commented Nov 1, 2019

although this allows for the tests to pass, is it invalidating the point of the tests?

Totally agree, but in this case the test was broken because a Flask error handler change, and it would cause to send the Access-Control-Allow-Originheader on a internal flask error; it's a bug, but not a breaking bug.

@jonringer
Copy link
Contributor

well, i guess slight broken is better than completely broken....

jonringer
jonringer approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (failures are unrelated)
diff LGTM
commits LGTM

[4 built (5 failed), 84 copied (154.0 MiB), 40.5 MiB DL]
error: build of '/nix/store/ahpxpabmhmlkgja9c0aqx5a8lzmh7wnz-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72479
5 package failed to build:
python37Packages.alerta-server python37Packages.blaze python37Packages.runway-python python38Packages.alerta-server python38Packages.runway-python

4 package were build:
flexget python27Packages.flask-cors python37Packages.flask-cors python38Packages.flask-cors

@jonringer jonringer merged commit f2f3682 into NixOS:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FlexGet / Flask CORS fails to build
2 participants
@marsam @jonringer