Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2: in console, typing _ or + zooms in and out the map #7816

Closed
nikolas opened this issue Nov 1, 2019 · 1 comment
Closed

SDL2: in console, typing _ or + zooms in and out the map #7816

nikolas opened this issue Nov 1, 2019 · 1 comment

Comments

@nikolas
Copy link
Member

nikolas commented Nov 1, 2019

Version of OpenTTD

1.10.0-beta1

Expected result

_ or + is entered into the console, but nothing else changes

Actual result

map zooms

Steps to reproduce

Go into console and type _ or +
@nikolas nikolas mentioned this issue Nov 3, 2019
Open
@James103
Copy link
Contributor

James103 commented Nov 3, 2019

Duplicate of #7783, according to @JGRennison.

The general issue here is that in SDL2, typing something not only types the character, but performs actions bound to the hotkey corresponding to the character typed. For example, typing a T will perform actions bound to the SHIFT+T hotkey, and typing a a will perform actions bound to the A hotkey. This also means that typing something like Hello will also perform the actions bound to the hotkeys SHIFT+H, E, L, L, and O, in that order.

This issue did not occur in SDL1, which my latest nightly version (2019-10-23) uses.

JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Nov 4, 2019
@JGRennison
Fix OpenTTD#7783, OpenTTD#7816: SDL2: Fix handling of shift key in ed…
cc2d606 
…it context

When in an edit context, input using only the shift key modifier
should not be interpreted as non-text input or as a hotkey.
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Nov 4, 2019
@JGRennison
Fix OpenTTD#7783, OpenTTD#7816: SDL2: Fix input handling in edit context
0728dc5 
In particular this fixes handling of the shift key
@JGRennison JGRennison mentioned this issue Nov 4, 2019
Merged
JGRennison added a commit to JGRennison/Upstream-OpenTTD that referenced this issue Nov 5, 2019
@JGRennison
Fix OpenTTD#7783, Fix OpenTTD#7816: [SDL2] Fix input handling in edit…
41ae84e 
… context

In particular this fixes handling of the shift key
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@JGRennison @douiwby
Fix OpenTTD#7783, Fix OpenTTD#7816: [SDL2] Fix input handling in edit…
9aee16f 
… context

In particular this fixes handling of the shift key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikolas @James103