Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] chromium: 78.0.3904.70 -> 78.0.3904.87 #72498

Merged
merged 1 commit into from Nov 2, 2019
Merged

[19.09] chromium: 78.0.3904.70 -> 78.0.3904.87 #72498

merged 1 commit into from Nov 2, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Nov 1, 2019

Motivation for this change

Backport #72497 to 19.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Still testing, I will only have test results tomorrow, so if anyone has CPU time please test this.

Notify maintainers

cc @bendlas

@obadz
Copy link
Contributor

obadz commented Nov 2, 2019

Does it matter that aarch64 isn't building?

@ivan
Copy link
Member Author

ivan commented Nov 2, 2019 via email

@obadz obadz merged commit 4c42323 into NixOS:release-19.09 Nov 2, 2019
@obadz
Copy link
Contributor

obadz commented Nov 2, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @obadz