[Chromedriver] Fix PerformAction to support multi touch points cases #20055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 1, 2019
For the multiple touch points case, if we have one point move and the other point stay still, such as point 1: pointerdown, pointermove, pointerup point 2: pointerdown, pause, pointerup We should send five touch point events of "pointerdown", "pointerdown", "pointermove", "pointerup", "pointerup" with pointer id 1, 2, 1, 1, 2. Bug: 1020674 Change-Id: I2a738154fee5a4356b64467fd9483c69429217d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895861 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#712684}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1895861
branch
from
8e9a60e
to
a5b724d
Compare
|
This is failing on Firefox. @whimboo does GeckoDriver support multi-touch? |
The problem lays deeper in the stack. We don't even support |
|
Alright let me create a metadata for Firefox to get this merged then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the multiple touch points case, if we have one point move and the
other point stay still, such as
point 1: pointerdown, pointermove, pointerup
point 2: pointerdown, pause, pointerup
We should send five touch point events of "pointerdown", "pointerdown",
"pointermove", "pointerup", "pointerup" with pointer id 1, 2, 1, 1, 2.
Bug: 1020674
Change-Id: I2a738154fee5a4356b64467fd9483c69429217d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895861
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712684}