Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT/common/security-features] Add more docs of generator and its types #20059

Merged
merged 1 commit into from Feb 13, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 2, 2019

Bug: 906850
Change-Id: Iceeb534baa175b6615bc69cfad921759ad460e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895926
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740446}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the chromium-export-cl-1895926 branch January 24, 2020 18:04
@gsnedders gsnedders restored the chromium-export-cl-1895926 branch January 24, 2020 18:51
@Hexcles Hexcles reopened this Jan 24, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1895926 branch 2 times, most recently from eda9119 to 90405d8 Compare February 10, 2020 23:50
Bug: 906850
Change-Id: Iceeb534baa175b6615bc69cfad921759ad460e71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895926
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740446}
@KyleJu
Copy link
Contributor

KyleJu commented Feb 13, 2020

@Hexcles Firefox and Chrome timeout. Please admin merge

@Hexcles Hexcles merged commit 18e8b18 into master Feb 13, 2020
@Hexcles Hexcles deleted the chromium-export-cl-1895926 branch February 13, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants