Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smplayer: 19.5.0 -> 19.10.0 #72660

Merged
merged 3 commits into from Nov 3, 2019
Merged

smplayer: 19.5.0 -> 19.10.0 #72660

merged 3 commits into from Nov 3, 2019

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Nov 3, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/smplayer/versions.

meta.description for smplayer is: '"A complete front-end for MPlayer"'.

meta.homepage for smplayer is: '"http://smplayer.sourceforge.net/"

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
smplayer

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/9q1gbz8cy82rj39x6hh876pxrjl51sf8-smplayer-19.10.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A smplayer https://github.com/r-ryantm/nixpkgs/archive/d19cc1fab3bc2f14dda1e97adf866785c48539c6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/9q1gbz8cy82rj39x6hh876pxrjl51sf8-smplayer-19.10.0
ls -la /nix/store/9q1gbz8cy82rj39x6hh876pxrjl51sf8-smplayer-19.10.0/bin

rnhmjoj
rnhmjoj approved these changes Nov 3, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using nix-review. All executables run and the player works fine.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/64

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2019

From https://www.smplayer.info/en/changes

Version 19.10
Fix for YouTube.
Fix control when using mpv 0.30.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2019 •
edited

At first launch it complains that

mplayer/mpw couldn't be launched. Check path to mplayer/mpv in the settings

I guess mplayer should be added as a default to buildInputs? It wouldn't prevent users to switch to mpv if available

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 3, 2019

I guess it worked because I have mpv in the path.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2019 •
edited

Yes. But the default would need to be in propagatedBuildInputs and I suppose it wasn't done before because we didn't want to "force" one or the other into users' profiles.
I'll just add some context in longDescription.

@c0bw3b c0bw3b self-assigned this Nov 3, 2019
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 3, 2019

Yes. But the default would need to be in propagatedBuildInputs and I suppose it wasn't done before because we didn't want to "force" one or the other into users' profiles.

I don't think putting mpv or mplayer in the buildInputs is going to do anything. It's probably looking for a binary mpv or mplayer in the PATH at runtime. So, it would have to be wrapped.

@c0bw3b c0bw3b mentioned this pull request Nov 3, 2019
Merged
8 tasks
@c0bw3b c0bw3b merged commit 7153c48 into NixOS:master Nov 3, 2019
@r-ryantm r-ryantm deleted the auto-update/smplayer branch November 4, 2019 05:03
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
@r-ryantm @dtzWill
smplayer: 19.5.0 -> 19.10.0
cb4b3b6 
* smplayer: 19.5.0 -> 19.10.0 (NixOS#72660)

(cherry picked from commit 7153c48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@c0bw3b c0bw3b c0bw3b left review comments

Assignees

@c0bw3b c0bw3b

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @nixos-discourse @c0bw3b @rnhmjoj @FRidh