Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trac: init at 1.4 #72455

Merged
merged 1 commit into from Nov 2, 2019
Merged

trac: init at 1.4 #72455

merged 1 commit into from Nov 2, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Nov 1, 2019 •
edited

Motivation for this change

trac: init at 1.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Nov 1, 2019
View reviewed changes
pkgs/tools/misc/trac/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
vyp
vyp suggested changes Nov 2, 2019
View reviewed changes
pkgs/tools/misc/trac/default.nix Outdated Show resolved Hide resolved
@risicle
Copy link
Contributor

risicle commented Nov 2, 2019

Bah can't test on darwin because of Babel's current brokenness https://hydra.nixos.org/build/104566946

@mmahut
Copy link
Member Author

mmahut commented Nov 2, 2019

Bah can't test on darwin because of Babel's current brokenness https://hydra.nixos.org/build/104566946

Indeed, will give it few minutes and try to fix it. If not, I will mark it as broken on darwin.

@risicle
Copy link
Contributor

risicle commented Nov 2, 2019

I'm not sure marking as broken is necessary - it's not this package's fault and "broken" markers have a habit of hanging around longer than necessary.

@mmahut
Copy link
Member Author

mmahut commented Nov 2, 2019 •
edited

@risicle I agree, I just excluded it in platforms.

@mmahut mmahut merged commit 107fc18 into NixOS:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp vyp requested changes

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmahut @risicle @vyp @jonringer