Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spirv-tools: 2019.3 -> 2019.4 #72457

Merged
merged 1 commit into from Nov 2, 2019
Merged

spirv-tools: 2019.3 -> 2019.4 #72457

merged 1 commit into from Nov 2, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 1, 2019 •
edited

Motivation for this change

noticed it was broken in hydra logs

broken by #71882, found through bisect

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72457
1 package were build:
spirv-tools

@jonringer jonringer requested a review from Ralith November 1, 2019 17:33
Ralith
Ralith approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonringer
Copy link
Contributor Author

nix-review passes
fixes broken build

[3 built, 1 copied (2.4 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72457
1 package were build:
spirv-tools

@jonringer jonringer merged commit 1092bd7 into NixOS:master Nov 2, 2019
@jonringer jonringer deleted the fix-spirv-tools branch November 2, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @Ralith