Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stone-phaser: init at 0.1.2 #72710

Merged
merged 1 commit into from Nov 16, 2019
Merged

stone-phaser: init at 0.1.2 #72710

merged 1 commit into from Nov 16, 2019

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Nov 3, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

vyp
vyp reviewed Nov 3, 2019
View reviewed changes
pkgs/applications/audio/stone-phaser/default.nix Outdated
];

patchPhase = ''
patch -d dpf -p 1 -i "`pwd`/resources/patch/DPF-bypass.patch"
Copy link
Member

@vyp vyp Nov 3, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
patch -d dpf -p 1 -i "`pwd`/resources/patch/DPF-bypass.patch"
patch -d dpf -p 1 -i "resources/patch/DPF-bypass.patch"

Is pwd needed here? The unpack phase should have copied the src to the current directory I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it is, without I get: patch: **** Can't open patch file resources/patch/DPF-bypass.patch : No such file or directory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, my bad 👍

@magnetophon
Copy link
Member Author

@marsam Wanna take a look here as well?

marsam
marsam reviewed Nov 16, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a pair of comments. Besides that, LGTM

pkgs/applications/audio/stone-phaser/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/stone-phaser/default.nix Outdated Show resolved Hide resolved
@marsam marsam merged commit 4800a71 into NixOS:master Nov 16, 2019
@magnetophon magnetophon deleted the stone-phaser branch November 16, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp vyp left review comments

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @marsam @vyp