Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

antimony: 2018-10-20 -> 2019-10-30 #72708

Merged
merged 1 commit into from Nov 7, 2019
Merged

antimony: 2018-10-20 -> 2019-10-30 #72708

merged 1 commit into from Nov 7, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Nov 3, 2019

Motivation for this change

Version bump and fix for #65399

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution and loaded a project.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@c0bw3b c0bw3b merged commit 5076d18 into NixOS:master Nov 7, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 7, 2019

@c0bw3b Thank you, could you cherry-pick this into 19.09 or should I open another?

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 7, 2019

Backported in 0d39ec2

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 7, 2019

Thank you again.

@rnhmjoj rnhmjoj deleted the sb branch January 8, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @c0bw3b