Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esphome: 1.13.6 -> 1.14.1 #72627

Merged
merged 1 commit into from Nov 9, 2019
Merged

esphome: 1.13.6 -> 1.14.1 #72627

merged 1 commit into from Nov 9, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 2, 2019 •
edited

Motivation for this change

noticed it was out of date while reviewing another package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from globin November 2, 2019 21:59
@globin
Copy link
Member

globin commented Nov 8, 2019

ofborg failure looks relevant

@jonringer
Copy link
Contributor Author

it does... not sure why it built locally, I'll fix it

@jonringer
Copy link
Contributor Author

paho-mqtt was bumped after I made the PR, should be fixed now

@globin globin merged commit 1f49029 into NixOS:master Nov 9, 2019
@jonringer jonringer deleted the bump-esphome branch November 9, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @globin