Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicacy: 2.1.2 -> 2.2.3 #72433

Merged
merged 1 commit into from Feb 12, 2020
Merged

duplicacy: 2.1.2 -> 2.2.3 #72433

merged 1 commit into from Feb 12, 2020

Conversation

ffinkdevs
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ehmry November 1, 2019 15:50
@marsam
Copy link
Contributor

marsam commented Nov 1, 2019 •
edited

please discard the deps.nix changes, since does not seem to be any in the changeset gilbertchen/duplicacy@v2.2.2...v2.2.3 sorry my bad, I misread the versions.

Please use dep2nix to update deps.nix https://github.com/nixcloud/dep2nix

@FRidh
Copy link
Member

FRidh commented Feb 10, 2020

@marsam ok now?

@FRidh
Copy link
Member

FRidh commented Feb 10, 2020

Ah, no, nothing changed I see.

@marsam
Copy link
Contributor

marsam commented Feb 12, 2020

@GrahamcOfBorg build duplicacy

@marsam marsam merged commit c384edd into NixOS:master Feb 12, 2020
@mmahut mmahut mentioned this pull request Feb 12, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ffinkdevs @marsam @FRidh