Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pfstools: build pfsalign (fix #60843) #61050

Merged
merged 1 commit into from Nov 2, 2019
Merged

pfstools: build pfsalign (fix #60843) #61050

merged 1 commit into from Nov 2, 2019

Conversation

juliendehos
Copy link
Contributor

Motivation for this change

Fix #60843

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented May 11, 2019

Builds for me, non-nixos linux x86_64, pfsalign appears to execute ok.

FYI it's possible to enable this package for darwin if you switch out the freeglut and libGLU_combined buildInputs like:

  ] ++ (if stdenv.isDarwin then (with darwin.apple_sdk.frameworks; [
    OpenGL GLUT
  ]) else [
    libGLU_combined freeglut
  ]);

The resulting pfsview has the same problems all nix Qt programs have on macos (#42893 et al), but other programs appear fine.

@risicle risicle mentioned this pull request May 12, 2019
Merged
10 tasks
@juliendehos
Copy link
Contributor Author

Thanks for this review. I have updated the PR.

c0bw3b
c0bw3b approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 61050 1

1 package were build:
  • pfstools
$ ./results/pfstools/bin/pfsalign -h
pfsalign [-r index|--reference index] [-c (min|max)|--crop (min|max)] [-d|--display-matches] [-f|--fail-no-match] -v -h
See man page for more information.

@c0bw3b c0bw3b merged commit 8ca3cad into NixOS:master Nov 2, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 3, 2020
@juliendehos @dtzWill
pfstools: build pfsalign (fix NixOS#60843) (NixOS#61050)
780357b 
(cherry picked from commit 8ca3cad)
@juliendehos juliendehos deleted the pfsalign branch March 25, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The "pfstools" package doesn't install the "pfsalign" program
3 participants
@juliendehos @risicle @c0bw3b