Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cointop: 1.3.4 -> 1.3.6 #72421

Merged
merged 1 commit into from Nov 1, 2019
Merged

cointop: 1.3.4 -> 1.3.6 #72421

merged 1 commit into from Nov 1, 2019

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Nov 1, 2019 •
edited

Motivation for this change

Update to latest

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@lsix
Copy link
Member

lsix commented Nov 1, 2019

Built and tested locally. All fine for me. Thanks

@lsix lsix merged commit 59653b0 into NixOS:master Nov 1, 2019
@prusnak prusnak deleted the cointop branch November 1, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @lsix