Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jabref: 3.8.1 -> 4.3.1 #72423

Closed
wants to merge 2 commits into from
Closed

jabref: 3.8.1 -> 4.3.1 #72423

wants to merge 2 commits into from

Conversation

BenBals
Copy link
Contributor

@BenBals BenBals commented Nov 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @gebner

@gebner
Copy link
Member

gebner commented Nov 1, 2019

Hmm, this does not even build for me:

installing
cp: cannot stat 'images/icons/JabRef-icon-mac.svg': No such file or directory
builder for '/nix/store/f11615w4fpiidaj9d651ps11931yvdxl-jabref-4.3.1.drv' failed with exit code 1
error: build of '/nix/store/f11615w4fpiidaj9d651ps11931yvdxl-jabref-4.3.1.drv' failed

The reason we haven't updated jabref is due to several issues:

  • jabref 4+ requires javafx
  • for a long time we didn't have a javafx package
  • now we have javafx for openjdk 11+, but jabref 4 doesn't support openjdk 11

Luckily, jabref 5 seems to support java 11 now: https://github.com/JabRef/jabref/releases/tag/v5.0-alpha

If we want to update jabref, then we should directly go to jabref 5 and use openjdk 11 or 12.

@BenBals
Copy link
Contributor Author

BenBals commented Nov 1, 2019

I see. Are you on Mac? As stated in the checklist, this built fine for me via nix-review. I don't know whether packages installed system wide could have made that work? (I'm quite new to making nix packages.)

@gebner
Copy link
Member

gebner commented Nov 1, 2019

No, I'm on nixos and I'm running nix-build -A jabref.

@GrahamcOfBorg build jabref

@gebner
Copy link
Member

gebner commented Nov 1, 2019

The build also fails on ofborg. Did you run nix-review wip? This will only check the uncommitted changes:

$ nix-review --help
...
    wip         review the uncommited changes in the working tree

If you've already committed the changes, then it won't do anything AFAIR. Personally, I typically run nix-build -A $attr manually for the attributes that are changed (or depend on the changes).

@BenBals
Copy link
Contributor Author

BenBals commented Nov 1, 2019

Okay, thanks, now I can reproduce.

@dtzWill
Copy link
Member

dtzWill commented Feb 28, 2020

v5 beta is available, FWIW: https://github.com/JabRef/jabref/releases/tag/v5.0-beta

Java is bundled now, maybe customized, so seems more of a FHSenv or autopatchelf sort of thing-- not sure. Anyone poked at this yet?

@stale
Copy link

stale bot commented Oct 31, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 31, 2020
@SuperSandro2000
Copy link
Member

jabref is now already on 5.0.1. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants