Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.schema: Fix #72690

Merged
merged 2 commits into from Nov 5, 2019
Merged

pythonPackages.schema: Fix #72690

merged 2 commits into from Nov 5, 2019

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Nov 3, 2019

This depends on contextlib2 and mock. The preConfigure hook
can probably be removed with the next version bump, see
keleshev/schema#222.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

This depends on contextlib2 and mock. The preConfigure hook
can probably be removed with the next version bump, see
keleshev/schema#222.
@FRidh
Copy link
Member

FRidh commented Nov 3, 2019

@GrahamcOfBorg build pythonPackages.schema

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
fixes broken build

[7 built (1 failed), 15 copied (12.7 MiB), 6.1 MiB DL]
error: build of '/nix/store/439xqsc9by2i95wkaqwyi12p23mnybir-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72690
1 package failed to build:
dvc-with-remotes

7 package were build:
dvc python27Packages.internetarchive python27Packages.schema python37Packages.internetarchive python37Packages.schema python38Packages.internetarchive python38Packages.schema

@jonringer jonringer merged commit 85fb935 into NixOS:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants