nixos/python: add pytest-bdd module. #72495
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/pytest-bdd-on-shell-nix/4616/6 |
| propagatedBuildInputs = [ glob2 Mako parse parse-type py pytest six ]; | ||
|
|
||
| # Tests require extra dependencies | ||
| doCheck = false; |
There was a problem hiding this comment.
that fine... just add them to checkInputs
| doCheck = false; | |
| checkInputs = [ mock ]; |
There was a problem hiding this comment.
After running the following command:
find pkgs/development/python-modules -name default.nix | xargs grep doCheck | grep pytest
I suspect we really need that doCheck = false.
There was a problem hiding this comment.
no... doCheck = false; will make it skip the checkPhase entirely
Here's how i would do this expression:
{ stdenv, buildPythonPackage, fetchFromGitHub
, execnet
, glob2
, Mako
, mock
, parse
, parse-type
, py
, pytest
, six
}:
buildPythonPackage rec {
pname = "pytest-bdd";
version = "3.2.1";
# tests are not included in pypi tarball
src = fetchFromGitHub {
owner = "pytest-dev";
repo = pname;
rev = version;
sha256 = "02y28l5h1m9grj54p681qvv7nrhd7ly9jkqdchyw4p0lnmcmnsrd";
};
propagatedBuildInputs = [ glob2 Mako parse parse-type py pytest six ];
checkInputs = [ execnet mock pytest ];
checkPhase = ''
pytest
'';
meta = with stdenv.lib; {
description = "BDD library for the py.test runner";
homepage = https://github.com/pytest-dev/pytest-bdd;
license = licenses.mit;
maintainers = with maintainers; [ jm2dev ];
};
}
There was a problem hiding this comment.
Thanks to that "fetchFromGitHub" now I'm aware of the available fetchers, and I suspect you have plenty of experience with python pips.
There was a problem hiding this comment.
I'm a co-owner of the nixpkgs python packages, only done a few hundred
|
also, to adhere to contributing guidelines, please rename the PR and commit to: |
you need to add yourself to maintainers, please look at #72312 as an example of commit message and history :) |
|
Hi, do we have any updates on this PR? |
| jm2dev = { | ||
| email = "jomarcar@gmail.com"; | ||
| github = "jm2dev"; | ||
| githubId = 474643; | ||
| name = "José Miguel Martínez Carrasco"; | ||
| }; |
There was a problem hiding this comment.
this should be a separate commit, look at #74389 as an example
There was a problem hiding this comment.
please reverse the order of the commits:
git rebase -i HEAD^^
# switch the two lines
# save
git push --force ...
There was a problem hiding this comment.
otherwise checking out the package commit will fail to evaluate
There was a problem hiding this comment.
Output of git log --oneline after following your instructions (and pushing to gh):
0bced444e7f (HEAD -> pytest-bdd, origin/pytest-bdd) pythonPackages.pytest-bdd: init at 3.2.1
b1601d57ec9 maintainers: add jm2dev
though github web doesn't show this way.
There was a problem hiding this comment.
ah, I looked at your branch, and it still showed it the other way. guess it is just the web view
jm2dev
force-pushed
the
pytest-bdd
branch
3 times, most recently
from
8a68b6c
to
78fa57a
Compare
|
@GrahamcOfBorg build python27Packages.pytest-bdd python37Packages.pytest-bdd python38Packages.pytest-bdd |
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @