New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kaiha/pr/readline #3196
Kaiha/pr/readline #3196
Conversation
9ab1a1d
to
2930ba8
Compare
2930ba8
to
40df2d4
Compare
Hm, I would prefer not to support more than one library due to the code duplication and the increased maintenance/testing burden. (Note that we got rid of readline in the past (c5f23f1)). |
BTW this looks pretty similar to #3110. |
Eelco Dolstra <notifications@github.com> writes:
Hm, I would prefer not to support more than one library due to the code duplication and the increased maintenance/testing burden. (Note that we got rid of readline in the past (c5f23f1)).
Yes, I know. I added it back as an option in [this PR][1], because the
libeditline used by Nix is not available in some Linux distribution.
And since the [packaging][2] [efforts][3] for Debian is taking up speed
again I thought it might be a good time to add these missing features.
[1]: #2551
[2]: https://salsa.debian.org/debian/nix
[3]: https://ftp-master.debian.org/new/nix_2.3.1-1.html
|
I marked this as stale due to inactivity. → More info |
With #3110 murdered, this is left as the remaining issue tracking readline in nix repl.
Is there any way these concerns could be addressed and we could move forward in some way here? The maintenance burden seems like it should be reasonable enough - the changes are relatively small and isolated to a single file that changes pretty infrequently (and afaik the patches haven't even had a conflict in years). It's also worth noting that these changes don't even strictly add support for a new library, they just improve the support that's already present (though presumably that support is not currently maintained / officially supported?) |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Implement completion and history for
nix repl
when compiled against libreadline instead of libeditline.