Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaiha/pr/readline #3196

Closed
wants to merge 2 commits into from
Closed

Kaiha/pr/readline #3196

wants to merge 2 commits into from

Conversation

KaiHa
Copy link
Contributor

@KaiHa KaiHa commented Nov 1, 2019

Implement completion and history for nix repl when compiled against libreadline instead of libeditline.

src/nix/repl.cc Outdated Show resolved Hide resolved
@edolstra
Copy link
Member

edolstra commented Nov 5, 2019

Hm, I would prefer not to support more than one library due to the code duplication and the increased maintenance/testing burden. (Note that we got rid of readline in the past (c5f23f1)).

@edolstra
Copy link
Member

edolstra commented Nov 5, 2019

BTW this looks pretty similar to #3110.

@KaiHa
Copy link
Contributor Author

KaiHa commented Nov 5, 2019 via email

@stale
Copy link

stale bot commented Feb 13, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Feb 13, 2021
@arcnmx
Copy link
Member

arcnmx commented Apr 16, 2022

With #3110 murdered, this is left as the remaining issue tracking readline in nix repl.

I would prefer not to support more than one library due to the code duplication and the increased maintenance/testing burden

Is there any way these concerns could be addressed and we could move forward in some way here? The maintenance burden seems like it should be reasonable enough - the changes are relatively small and isolated to a single file that changes pretty infrequently (and afaik the patches haven't even had a conflict in years).

It's also worth noting that these changes don't even strictly add support for a new library, they just improve the support that's already present (though presumably that support is not currently maintained / officially supported?)

@stale stale bot removed the stale label Apr 16, 2022
@KaiHa KaiHa closed this Oct 11, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-repl-and-readline/31655/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants