Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esptool: 2.7 -> 2.8 #72492

Closed
wants to merge 1 commit into from
Closed

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Nov 1, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/esptool/versions.

meta.description for esptool is: '"ESP8266 and ESP32 serial bootloader utility"'.

meta.homepage for esptool is: '"https://github.com/espressif/esptool"

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
esphome
esptool

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A esptool https://github.com/r-ryantm/nixpkgs/archive/c07e12d5fb7d34e54c0289fdb6088043eab37ed0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8
ls -la /nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8/bin

cc @dezgeg @dotlambda for testing.

@Mic92
Copy link
Member

Mic92 commented Nov 2, 2019

espefuse.py tries to import our wrapped esptool, which fails due being wrapped.

$ espefuse.py
Traceback (most recent call last):
  File "/nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8/bin/.espefuse.py-wrapped", line 22, in <module>
    import esptool
  File "/nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8/bin/esptool.py", line 2
    export PATH='/nix/store/zdh16dcvjw99ybam59zd2ijb6bx138j0-python3-3.7.5/bin:/nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8/bin:/nix/store/2w9f7hqjnkv6xw63p3jvjr5z6m12d0w5-python3.7-pyserial-3.4/bin'${PATH:+':'}$PATH
              ^
SyntaxError: invalid syntax

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/99

@Mic92
Copy link
Member

Mic92 commented Feb 13, 2020

A fix could be to copy the scripts to a different directory than $out/bin and only put the wrapper into $out/bin so that espfuse.py can still import the other module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants