[FlexNG] Make items honor indefinite percentage resolution size #20056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 2, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1895746
branch
3 times, most recently
from
1a1cbb2
to
b2ed44c
Compare
We'd already been setting SetIsFixedBlockSizeIndefinite properly, but children weren't paying attention because we weren't setting their percentage resolution sizes with CalculateChildPercentageSize. Bug: 845235 Change-Id: I09a6a0414e4fde8ee6cdd146e056c50d718dbc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895746 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#713323}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1895746
branch
from
b2ed44c
to
ad3a803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd already been setting SetIsFixedBlockSizeIndefinite properly, but
children weren't paying attention because we weren't setting their
percentage resolution sizes with CalculateChildPercentageSize.
Bug: 845235
Change-Id: I09a6a0414e4fde8ee6cdd146e056c50d718dbc87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895746
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713323}