Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.checkmanifest: fix build #72607

Merged
merged 1 commit into from Nov 2, 2019
Merged

pythonPackages.checkmanifest: fix build #72607

merged 1 commit into from Nov 2, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 2, 2019 •
edited

Motivation for this change

noticed it was broken when reviewing #72475

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

original error:

builder for '/nix/store/j3xhy6hmv970calgxarhq2xgk52wz8ny-python3.7-check-manifest-0.40.drv' failed with exit code 1; last 10 log lines:
  adding 'check_manifest-0.40.dist-info/top_level.txt'
  adding 'check_manifest-0.40.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  Finished executing setuptoolsInstallPhase
  installing
  Executing pipInstallPhase
  /build/check-manifest-0.40/dist /build/check-manifest-0.40
  Processing ./check_manifest-0.40-py2.py3-none-any.whl
  ERROR: Could not find a version that satisfies the requirement toml (from check-manifest==0.40) (from versions: none)
  ERROR: No matching distribution found for toml (from check-manifest==0.40)
cannot build derivation '/nix/store/wkkk69aiby4p53442q4j4hcc91phsvp5-devpi-client-5.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/k1dmrw7mkkvc0krc2gws4jsdhnx7k39v-env.drv': 1 dependencies couldn't be built

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72607
4 package were build:
devpi-client python27Packages.check-manifest python37Packages.check-manifest python38Packages.check-manifest

@jonringer jonringer requested a review from FRidh as a code owner November 2, 2019 18:18
@ofborg ofborg bot requested a review from nlewo November 2, 2019 18:32
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build devpi-client python27Packages.check-manifest python37Packages.check-manifest python38Packages.check-manifest

@jonringer
Copy link
Contributor Author

fixes a broken build, merging

@jonringer jonringer merged commit 708787c into NixOS:master Nov 2, 2019
@jonringer jonringer deleted the fix-checkmanifest branch November 4, 2019 20:50
@jonringer jonringer mentioned this pull request Nov 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer