Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcab: 1.2 -> 1.3 #72525

Merged
merged 5 commits into from Nov 7, 2019
Merged

gcab: 1.2 -> 1.3 #72525

merged 5 commits into from Nov 7, 2019

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Nov 2, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gcab/versions.

meta.description for gcab is: '""'.

meta.homepage for gcab is: '"https://wiki.gnome.org/msitools"

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

21 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
6 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
discover
fwupd
gcab
gnome-firmware-updater
gnome3.gnome-software
msitools
plasma5.discover

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/da325rzdn06b1s8npnvr8nihw1901h1v-gcab-1.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A gcab https://github.com/r-ryantm/nixpkgs/archive/b3ba1a8fad79331bb44f2c6687cc5c2b84e0e2f8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/da325rzdn06b1s8npnvr8nihw1901h1v-gcab-1.3
ls -la /nix/store/da325rzdn06b1s8npnvr8nihw1901h1v-gcab-1.3/bin

cc @lethalman for testing.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 6, 2019

Now supports installed tests, perhaps we should add them after #72860

http://ftp.gnome.org/pub/GNOME/sources/gcab/1.3/gcab-1.3.news

Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 72525 1

6 package were build:
  • discover (plasma5.discover)
  • fwupd (plasma5.discover)
  • gcab (plasma5.discover)
  • gnome-firmware-updater (plasma5.discover)
  • gnome3.gnome-software (plasma5.discover)
  • msitools (plasma5.discover)

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 6, 2019

@jtojnar that would mean add an installedTests output and the proper meson flags to install them?

@jtojnar
Copy link
Contributor

jtojnar commented Nov 6, 2019

@jtojnar jtojnar self-assigned this Nov 7, 2019
jtojnar and others added 3 commits November 7, 2019 14:01
* format with nixpkgs-fmt
* remove UTF-8 locale hack, since now we have C.UTF-8
* add description, fix homepage, correct license
* split to multiple outputs
also add nixosTests.installed-tests.gcab for running the installed tests
@jtojnar
Copy link
Contributor

jtojnar commented Nov 7, 2019

@GrahamcOfBorg test installed-tests.gcab

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libgcab-1.0.pc has gio-2.0 in its Requires.

@worldofpeace worldofpeace merged commit 4dc696b into NixOS:master Nov 7, 2019
@ofborg ofborg bot requested a review from worldofpeace November 7, 2019 14:09
@r-ryantm r-ryantm deleted the auto-update/gcab branch November 16, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants