New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vapoursynth-editor: use qt's mkDerivation #72465
Conversation
This needs a backport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This program is already wrapped, so wrapQtAppsHook
will ignore wrapping it. This is because it ignores scripts.
What you can do is use wrapQtApp
in place of wrapProgram
and set dontWrapQtApps = true;
as we're wrapping manually. You should then remove makeWrapper
from this expression.
Note, wrapping should happen in |
It does seem to work anyway, but wrapping a program twice probably isn't great. |
977c09b
to
d183f71
Compare
This was the content of the wrapper without using
so it was actually broken. Here's the content of the wrapper in the latest commit
LGTM 👍 I can perform the backport manually for you as well. |
Yeah,
Thanks! |
backported in 82b6998.
No problem, thank you too ✨ |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @