Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

muparser: add darwin support #72624

Merged
merged 1 commit into from Nov 5, 2019
Merged

muparser: add darwin support #72624

merged 1 commit into from Nov 5, 2019

Conversation

witkamp
Copy link
Contributor

@witkamp witkamp commented Nov 2, 2019

Add Darwin support
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@witkamp
Copy link
Contributor Author

witkamp commented Nov 4, 2019

@LnL7 I rebased on master.

@LnL7 LnL7 merged commit f48ecbf into NixOS:master Nov 5, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
@LnL7 @dtzWill
Merge pull request NixOS#72624 from witkamp/master
02af1a4 
muparser: add darwin support
(cherry picked from commit f48ecbf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@witkamp @LnL7