Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3status: 2.12 -> 2.13 #68289

Merged
merged 2 commits into from Sep 8, 2019
Merged

i3status: 2.12 -> 2.13 #68289

merged 2 commits into from Sep 8, 2019

Conversation

exi
Copy link
Contributor

@exi exi commented Sep 7, 2019

Update i3status to 2.13.
I needed to add a little hack to get it to build because for reasons
I can't seem to figure out, the configure script generates a broken
Makefile on this release.
The small sed line fixes the syntax error.

Motivation for this change

Wanted the new read_file feature for i3status

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin

@exi
i3status: 2.12 -> 2.13
8f6cdc6 
Update i3status to 2.13.
I needed to add a little hack to get it to build because for reasons
I can't seem to figure out, the configure script generates a broken
Makefile on this release.
The small sed line fixes the syntax error.
Ma27
Ma27 approved these changes Sep 8, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested locally. Also fixed the package's description.

@Ma27
Copy link
Member

Ma27 commented Sep 8, 2019

@GrahamcOfBorg build i3status

@Ma27 Ma27 merged commit 5972fba into NixOS:master Sep 8, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 8, 2019

@exi thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@exi @Ma27 @Mic92