Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nexus: 3.16.1-02 -> 3.18.1-01 #68288

Merged
merged 1 commit into from Sep 8, 2019
Merged

nexus: 3.16.1-02 -> 3.18.1-01 #68288

merged 1 commit into from Sep 8, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 7, 2019

Motivation for this change

https://help.sonatype.com/repomanager3/release-notes/2019-release-notes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ironpinguin @zaninime @aespinosa

Copy link
Contributor

@ironpinguin ironpinguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@aespinosa aespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ma27 Ma27 merged commit f3ad897 into NixOS:master Sep 8, 2019
@Ma27 Ma27 deleted the bump-nexus branch September 8, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants