Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra: 2019-05-06 -> 2019-08-30 #68291

Merged
merged 3 commits into from Sep 14, 2019
Merged

hydra: 2019-05-06 -> 2019-08-30 #68291

merged 3 commits into from Sep 14, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 7, 2019

Motivation for this change

Bump to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested on NixOS x86_64; my Hydra is still working after updating to this.

We ship `https://cache.nixos.org` as binary cache by default which
automatically substitutes the test derivation used inside the Hydra
test. However it needs to be built locally to confirm that
`hydra-queue-runner` works properly.

Also inherited the platform name for the test derivation from `system`
to ensure that the build can be tested on each supported platform.

ZHF NixOS#68361
During the last update, `hydra-notify` was rewritten as a daemon which
listens to postgresql notifications for each build[1]. The module
uses the `hydra-notify.service` unit from upstream's Hydra module and
the VM test ensures that email notifications are sent properly.

Also updated `hydra-init.service` to install `pg_trgm` on a local
database if needed[2].

[1] NixOS/hydra@c7861b8
[2] NixOS/hydra@8a0a5ec
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 14, 2019
@Ma27
Copy link
Member Author

Ma27 commented Sep 14, 2019

At least the fix for the Hydra test should be ported to release-19.09. I deployed those patches to my personal Hydra instance (which currently runs on 19.09) and this appears to work fine now :)

@WilliButz WilliButz merged commit cbb6293 into NixOS:master Sep 14, 2019
@Ma27 Ma27 deleted the bump-hydra branch September 14, 2019 11:16
@WilliButz
Copy link
Member

backported all to 19.09 in d16b279, 4ab56cb and cb48999

@WilliButz WilliButz removed the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants