Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ppx_deriving_protobuf: init at 2.7 #68304

Merged
merged 1 commit into from Sep 13, 2019
Merged

ocamlPackages.ppx_deriving_protobuf: init at 2.7 #68304

merged 1 commit into from Sep 13, 2019

Conversation

vyorkin
Copy link
Member

@vyorkin vyorkin commented Sep 8, 2019 •
edited

Motivation for this change

Add ppx_deriving_protobuf: A Protocol Buffers codec generator for OCaml.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@vyorkin vyorkin force-pushed the ocaml-ppx_deriving_protobuf-2.7 branch from 1049f67 to 07f0307 Compare September 13, 2019 12:46
@vyorkin
Copy link
Member Author

vyorkin commented Sep 13, 2019

I've updated the PR

@vbgl
Copy link
Contributor

vbgl commented Sep 13, 2019

@GrahamcOfBorg build ocamlPackages.ppx_deriving_protobuf

@vbgl vbgl merged commit 2b92113 into NixOS:master Sep 13, 2019
@vyorkin vyorkin deleted the ocaml-ppx_deriving_protobuf-2.7 branch December 5, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vyorkin @vbgl @lheckemann