Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tippecanoe: init at 1.34.3 #68303

Merged
merged 2 commits into from Sep 9, 2019
Merged

tippecanoe: init at 1.34.3 #68303

merged 2 commits into from Sep 9, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Sep 8, 2019

Motivation for this change

https://github.com/mapbox/tippecanoe

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir
Copy link
Member Author

sikmir commented Sep 8, 2019

@GrahamcOfBorg build tippecanoe

@risicle
Copy link
Contributor

risicle commented Sep 8, 2019

nix-review happy for me, macos 10.13 & non-nixos linux x86_64. Binaries appear to work.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 8, 2019

@GrahamcOfBorg build tippecanoe

@jtojnar
Copy link
Contributor

jtojnar commented Sep 8, 2019

Would it make sense to run tests by setting doCheck = true;?

@sikmir
Copy link
Member Author

sikmir commented Sep 8, 2019

Would it make sense to run tests by setting doCheck = true;?

Added.

@jtojnar jtojnar merged commit c65f597 into NixOS:master Sep 9, 2019
@sikmir sikmir deleted the tippecanoe branch September 10, 2019 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants