New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yaru-theme: init at 19.10.2 #68302
yaru-theme: init at 19.10.2 #68302
Conversation
I was running @dtzWill's PR with mostly success (had one small issue with oversized cursors in some situations with the Yaru cursor theme, but I'm pretty sure that's an issue with my system/gtk/wayland/etc). This LGTM. Thanks! |
pkgs/data/themes/yaru/default.nix
Outdated
python3, gtk3, gnome3, gtk-engine-murrine }: | ||
|
||
stdenv.mkDerivation rec { | ||
name = "yaru-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "yaru-${version}"; | |
pname = "yaru"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, TIL!
pkgs/data/themes/yaru/default.nix
Outdated
|
||
stdenv.mkDerivation rec { | ||
name = "yaru-${version}"; | ||
version = "19.10.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs update https://github.com/ubuntu/yaru/releases/tag/19.10.2
This interestingly uses gnome-session modes and provides a Yaru session. |
Oh, is that what it's doing? I have to admit that I didn't really understand what I was writing when adding your gnome-related suggestions from the last PR :) |
Tested locally. Looks good. |
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Closes #66698 (also see #51153).