Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaru-theme: init at 19.10.2 #68302

Merged
merged 1 commit into from Sep 21, 2019
Merged

yaru-theme: init at 19.10.2 #68302

merged 1 commit into from Sep 21, 2019

Conversation

jD91mZM2
Copy link
Member

@jD91mZM2 jD91mZM2 commented Sep 8, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Closes #66698 (also see #51153).

@colemickens
Copy link
Member

I was running @dtzWill's PR with mostly success (had one small issue with oversized cursors in some situations with the Yaru cursor theme, but I'm pretty sure that's an issue with my system/gtk/wayland/etc).

This LGTM. Thanks!

python3, gtk3, gnome3, gtk-engine-murrine }:

stdenv.mkDerivation rec {
name = "yaru-${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "yaru-${version}";
pname = "yaru";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, TIL!


stdenv.mkDerivation rec {
name = "yaru-${version}";
version = "19.10.1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worldofpeace
Copy link
Contributor

This interestingly uses gnome-session modes and provides a Yaru session.

@jD91mZM2
Copy link
Member Author

Oh, is that what it's doing? I have to admit that I didn't really understand what I was writing when adding your gnome-related suggestions from the last PR :)

@jD91mZM2 jD91mZM2 changed the title yaru-theme: init at 19.10.1 yaru-theme: init at 19.10.2 Sep 20, 2019
@romildo romildo requested review from romildo and removed request for romildo September 21, 2019 15:10
@romildo
Copy link
Contributor

romildo commented Sep 21, 2019

Tested locally. Looks good.

@romildo romildo merged commit da6e307 into NixOS:master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package request: yaru theme (communitheme) from ubuntu
5 participants