Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nano-wallet: 18.0 -> 19.0 #68315

Merged
merged 2 commits into from Sep 8, 2019
Merged

nano-wallet: 18.0 -> 19.0 #68315

merged 2 commits into from Sep 8, 2019

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Sep 8, 2019 •
edited

Motivation for this change

Update Nano cryptocurrency wallet.

NOTE: This is still work in progress! Any help appreciated. EDIT: Works now.

I'm getting the following error when running nano_wallet:

$ nano_wallet
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-org.kde.kwin.qpa.

Any ideas how to solve this?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine
Copy link
Member Author

jluttine commented Sep 8, 2019

Hmm.. I think I found all relevant help from here: #68309

Let's see if it works now..

jb55
jb55 reviewed Sep 8, 2019
View reviewed changes
Copy link
Contributor

@jb55 jb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these commits are signed with an expired key, just a heads up.

@jluttine
Copy link
Member Author

jluttine commented Sep 8, 2019

Works now!

@jluttine
Copy link
Member Author

jluttine commented Sep 8, 2019

Oh, thanks for the heads up! Have to fix my key at some point then.

@mmahut
Copy link
Member

mmahut commented Sep 8, 2019

@GrahamcOfBorg build nano-wallet

@mmahut mmahut merged commit df3b84a into NixOS:master Sep 8, 2019
@worldofpeace
Copy link
Contributor

If this is a qt application entirely, it should use mkDerivation which is from qt and it automatically adds wrapQtAppsHook. The aforementioned PR #68309 actually has changes to reflect that which I requested there also.

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 2, 2019
@mmahut @dtzWill
Merge pull request NixOS#68315 from jluttine/nano-wallet-19.0
31e46d2 
nano-wallet: 18.0 -> 19.0
(cherry picked from commit df3b84a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jluttine @mmahut @worldofpeace @jb55