Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonic-pi: fix qt wrapper #68309

Merged
merged 1 commit into from Sep 9, 2019
Merged

sonic-pi: fix qt wrapper #68309

merged 1 commit into from Sep 9, 2019

Conversation

c0deaddict
Copy link
Member

Motivation for this change

Currently sonic-pi crashes with the following exception:

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

/nix/store/989cr57j8cj1zh4fwj63xs3378phlz4j-sonic-pi-3.1.0/bin/.sonic-pi-wrapped: line 20: 14215 Aborted                 (core dumped) $DIR/../app/gui/qt/sonic-pi

This PR fixes that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

Can you change

supercollider = libsForQt5.callPackage ../../../development/interpreters/supercollider

to

supercollider_single_prec = supercollider.override {  fftw = fftwSinglePrec; };

@jluttine jluttine mentioned this pull request Sep 8, 2019
Merged
10 tasks
@c0deaddict
Copy link
Member Author

Can you change

supercollider = libsForQt5.callPackage ../../../development/interpreters/supercollider

to

supercollider_single_prec = supercollider.override {  fftw = fftwSinglePrec; };

done!

worldofpeace
worldofpeace approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the application was wrapped and built.

@worldofpeace worldofpeace merged commit 259202c into NixOS:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@Phlogistique Phlogistique Awaiting requested review from Phlogistique

@kamilchm kamilchm Awaiting requested review from kamilchm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0deaddict @worldofpeace