Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8: add pkgconfig file #68292

Merged
merged 1 commit into from Sep 12, 2019
Merged

v8: add pkgconfig file #68292

merged 1 commit into from Sep 12, 2019

Conversation

matthewbauer
Copy link
Member

This is not provided by the v8 team, we need to provide a custom one.

https://bugs.chromium.org/p/v8/issues/detail?id=2184

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthewbauer
v8: add pkgconfig file
283358e 
This is not provided by the v8 team, we need to provide a custom one.

https://bugs.chromium.org/p/v8/issues/detail?id=2184
@ofborg ofborg bot requested a review from cstrahan September 8, 2019 01:34
@matthewbauer matthewbauer mentioned this pull request Sep 8, 2019
Closed
@WilliButz WilliButz merged commit a981edb into NixOS:master Sep 12, 2019
@risicle
Copy link
Contributor

risicle commented Jan 5, 2020

😕 has anyone had this working for them? For me, pkg-config --modversion v8 gives me Libs field occurs twice in '/nix/store/sbp7780f54vs3hm1d7smm0lyfsv5d41b-v8-7.4.255/lib/pkgconfig/v8.pc

@matthewbauer
Copy link
Member Author

Yeah second Cflags & Libs need to be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@WilliButz WilliButz WilliButz approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @risicle @Mic92 @WilliButz