inkscape: add wrapGAppsHook for icons (fixed for strictDeps) #68287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jtojnar |
jtojnar
reviewed
Sep 8, 2019
rileyinman
force-pushed
the
inkscape-strictdeps
branch
from
36e7003
to
ae5bf15
Compare
Resolves NixOS#68185. The icons in Inkscape depend on gdk-pixbuf loaders, but because strictDeps is set to true to fix some macOS issues it doesn't work (see NixOS#56943). Adding librsvg to buildInputs explicitly fixes the issue.
rileyinman
force-pushed
the
inkscape-strictdeps
branch
from
ae5bf15
to
cd04b61
Compare
|
Thanks. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #68185.
The icons in Inkscape depend on gdk-pixbuf loaders, but because
strictDeps is set to true to fix some macOS issues it doesn't work
(see #56943). Adding librsvg to buildInputs explicitly fixes the issue.
Motivation for this change
I want to be able to use Inkscape and icons are kind of important :P
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)