Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris: 0.5.2.1 -> 0.5.3 #68293

Merged
merged 1 commit into from Sep 8, 2019
Merged

lutris: 0.5.2.1 -> 0.5.3 #68293

merged 1 commit into from Sep 8, 2019

Conversation

valencik
Copy link
Contributor

@valencik valencik commented Sep 8, 2019

Motivation for this change

This PR bumps the version of lutris to 0.5.3 which fixes numerous issues (https://github.com/lutris/lutris/releases/tag/v0.5.3), among them hanging installs of GOG games (lutris/lutris#2173).

Things done

Modified package locally and tested with nix-build -A lutris.
It built successfully and now installs my GOG games without issue :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar @Chiiruno @infinisil

@valencik valencik changed the title Update Lutris to 0.5.3 lutris: 0.5.2.1 -> 0.5.3 Sep 8, 2019
@ofborg ofborg bot requested a review from Chiiruno September 8, 2019 03:44
@abbradar abbradar merged commit 3ae9f16 into NixOS:master Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valencik @abbradar @Janik-Haag