Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.vim-gui-position: init at 2019-06-06 #68294

Merged
merged 1 commit into from Sep 21, 2019
Merged

vimPlugins.vim-gui-position: init at 2019-06-06 #68294

merged 1 commit into from Sep 21, 2019

Conversation

millerjason
Copy link
Contributor

@millerjason millerjason commented Sep 8, 2019 •
edited

Motivation for this change

add missing module to support restoring vim window size and position on restarts

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

timokau
timokau approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you and welcome to the team :)

@timokau timokau merged commit 60a897d into NixOS:master Sep 21, 2019
@millerjason millerjason deleted the vim-plugins-vim-gui-position branch September 22, 2019 03:49
@millerjason
Copy link
Contributor Author

millerjason commented Sep 22, 2019 •
edited

Appreciate you looking at my request. Thank you, @timokau.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@millerjason @timokau @Janik-Haag