Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdesktopenv: init at 2019-11-30 #68301

Merged
merged 1 commit into from Dec 21, 2019
Merged

cdesktopenv: init at 2019-11-30 #68301

merged 1 commit into from Dec 21, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 8, 2019 •
edited by ghost

Motivation for this change

The Common Desktop Environment was created by a collaboration of Sun, HP, IBM, DEC, SCO, Fujitsu and Hitachi. Used on a selection of commercial UNIXs, it is now available as open-source software for the first time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @joachifm

@ghost ghost mentioned this pull request Sep 8, 2019
Closed
@ghost ghost closed this Sep 8, 2019
@ghost ghost deleted the cde2 branch September 8, 2019 10:10
@ghost ghost restored the cde2 branch November 3, 2019 17:06
@ghost ghost reopened this Nov 3, 2019
@ghost ghost mentioned this pull request Nov 3, 2019
Closed
@ghost ghost closed this Nov 3, 2019
@ghost ghost reopened this Nov 4, 2019
@ghost ghost changed the title [WIP] cde / cdesktopenv cdesktopenv: init at 2019-11-30 Dec 6, 2019
@ghost ghost marked this pull request as ready for review December 6, 2019 20:13
@ghost
Copy link
Author

ghost commented Dec 6, 2019

@GrahamcOfBorg build cdesktopenv

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/cde-common-desktop-environment-is-available-for-nixos/5049/1

markuskowa
markuskowa approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test in a Virtualbox. Looks pretty good.

@markuskowa markuskowa merged commit 898f188 into NixOS:master Dec 21, 2019
@ghost
Copy link
Author

ghost commented Dec 21, 2019

@markuskowa Thank you!

@ghost ghost deleted the cde2 branch December 21, 2019 12:44
@ghost ghost mentioned this pull request May 13, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nixos-discourse @markuskowa