Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strawberry: environment variable was missing #68297

Merged
merged 1 commit into from Sep 8, 2019
Merged

strawberry: environment variable was missing #68297

merged 1 commit into from Sep 8, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

The earlier PR didn't have the right commit - it wasn't actually able to play music.....

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

worldofpeace
worldofpeace approved these changes Sep 8, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened a file and I could play music. Verified that the GST_PLUGIN_SYSTEM_PATH_1_0 variable was in the wrapper and expanded.

@worldofpeace worldofpeace merged commit 84b39ae into NixOS:master Sep 8, 2019
@peterhoeg peterhoeg deleted the f/strawberry branch September 9, 2019 06:27
@peterhoeg peterhoeg restored the f/strawberry branch September 11, 2019 06:22
@peterhoeg peterhoeg deleted the f/strawberry branch September 13, 2019 09:52
@peterhoeg peterhoeg restored the f/strawberry branch September 13, 2019 11:03
@peterhoeg peterhoeg deleted the f/strawberry branch September 24, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @worldofpeace