Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: Enable X86_AMD_PLATFORM_DEVICE #68312

Merged
merged 1 commit into from Sep 9, 2019
Merged

Conversation

mat8913
Copy link
Contributor

@mat8913 mat8913 commented Sep 8, 2019

Motivation for this change

This is needed to get the touchpad working on my Acer Nitro laptop.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @NeQuissimus

This is needed to get the toupad working on my Acer Nitro laptop.
@NeQuissimus
Copy link
Member

@GrahamcOfBorg test kernel-latest

@NeQuissimus
Copy link
Member

Considering it's prefixed X86, is this going to break the ARM kernel builds?

@flokli flokli requested a review from samueldr September 8, 2019 16:14
@samueldr
Copy link
Member

samueldr commented Sep 8, 2019

When building on AArch64:

...
warning: unused option: X86_AMD_PLATFORM_DEVICE
...

Among other options. So it looks like it's fine on non-x86 to keep the option as yes.

Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option was added in 4.0, so I guess it's fine without version specific conditionals, considering the range of kernels held in nixpkgs

~/tmp/nixpkgs/nixpkgs $ nix eval '(with import ./. {}; builtins.map (attr: pkgs."${attr}".version) (builtins.filter (lib.strings.hasPrefix "linux_") (builtins.attrNames pkgs)))'
[ "4.14.141" "4.19.69" "4.4.190" "4.9.190" "5.2.11" "4.19.69" "4.14.120-160" "4.14.120-160" "5.2.11" "5.2.11" "5.2.11" "4.19.55-mptcp_v0.95" "4.14.127-mptcp_v0.94.6" "4.19.55-mptcp_v0.95" "4.14.98-1.20190215" "5.2-rc7" "5.1.2019.08.21" "5.2-rc7" ]

Note for other maintainers: it would be nice to have proper guidelines stating from which kernel version condtionals should be added. Though I figure going from the lower bounds in nixpkgs is alright.

@samueldr samueldr merged commit 667712a into NixOS:master Sep 9, 2019
@mat8913 mat8913 deleted the patch-2 branch September 9, 2019 13:50
@mat8913 mat8913 restored the patch-2 branch September 12, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants