Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vk-messenger: use wrapGAppsHook #76129

Merged
merged 1 commit into from Dec 21, 2019
Merged

vk-messenger: use wrapGAppsHook #76129

merged 1 commit into from Dec 21, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 21, 2019

Motivation for this change

This fixes a crash when adding an image from computer to a chat.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

worldofpeace
worldofpeace approved these changes Dec 21, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gnome maintainer approval on my side 👍

@worldofpeace worldofpeace merged commit 9e1e7e3 into NixOS:master Dec 21, 2019
@ghost
Copy link
Author

ghost commented Dec 21, 2019

@worldofpeace Thank you!

@ghost ghost deleted the vk branch December 21, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace