Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

afl: 2.52b -> 2.56b #76138

Merged
merged 1 commit into from Dec 30, 2019
Merged

afl: 2.52b -> 2.56b #76138

merged 1 commit into from Dec 30, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Dec 21, 2019

Motivation for this change

Bump.

I'd appreciate a user of e.g. the llvm mode to test this because I only use the qemu mode.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice

@risicle
afl: 2.52b -> 2.56b
9621a8d 
can remove qemu glibc patch as it is now covered by afl's own patches
@ofborg ofborg bot requested a review from thoughtpolice December 21, 2019 15:52
ruuda
ruuda approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@ruuda ruuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested compiling a program with afl-gcc and then fuzzing it with afl-fuzz, it appears to work fine.

thoughtpolice
thoughtpolice approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the README, etc too. Approved.

@thoughtpolice thoughtpolice merged commit de0e717 into NixOS:master Dec 30, 2019
@thoughtpolice thoughtpolice self-assigned this Dec 30, 2019
@risicle
Copy link
Contributor Author

risicle commented Dec 30, 2019

Thanks for updating the README, etc too. Approved.

Heh, note how I abandoned the whole thing entirely in the AFL++ PR #76645 in favour of a bruteforce blanket solution that shouldn't need continued manual tinkering. Might bring this back to AFL some day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@ruuda ruuda ruuda approved these changes

Assignees

@thoughtpolice thoughtpolice

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @thoughtpolice @ruuda