Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 1.7.1 -> 1.7.2 #76097

Merged
merged 1 commit into from Dec 21, 2019
Merged

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 20, 2019

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/1.7.2

Building for now with Python 3.7 as Python 3.8.1 changed it's behavior
regarding URL parsing[1] which broke one of its dependencies[2].

[1] https://bugs.python.org/issue27657
[2] https://hydra.nixos.org/build/108652790 / mozilla/bleach#503

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@pacien
Copy link
Contributor

pacien commented Dec 20, 2019

Maybe add a comment referencing #76093 so that we keep track of this.

@ofborg test matrix-synapse

https://github.com/matrix-org/synapse/releases/tag/1.7.2

Building for now with Python 3.7 as Python 3.8.1 changed it's behavior
regarding URL parsing[1] which broke one of its dependencies[2].

[1] https://bugs.python.org/issue27657
[2] https://hydra.nixos.org/build/108652790 / mozilla/bleach#503
@Ma27
Copy link
Member Author

Ma27 commented Dec 20, 2019

Maybe add a comment referencing #76093 so that we keep track of this.

👍 - updated

@ofborg ofborg bot requested a review from pacien December 20, 2019 18:41
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully upgraded 👍

@WilliButz WilliButz merged commit 3f998fa into NixOS:master Dec 21, 2019
@WilliButz
Copy link
Member

backported in 9683818

@WilliButz WilliButz added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 21, 2019
@Ma27 Ma27 deleted the bump-matrix-synapse branch December 21, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants